Viewports: Fix window having incorrect size after it is uncollapsed #2756
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue manifests on linux when window is in it's own viewport.
Why it happened
Event sets
PlatformRequestResize = true
which causes this line to execute and save size of collapsed window as full size.SDL backend does not send window resize event when
SDL_SetWindowSize()
is called and everything works as expected.On windows glfw still sends this event, but event is sent during
glfwSetWindowSize()
call which is invoked from here. Due to lucky accidentPlatformRequestSize
is cleared soon after imgui requests setting window size. It works on windows by chance.On linux event is queued and sent to application on next frame during
glfwPollEvents()
. Then imgui gets a chance to react onPlatformRequestSize
flag and save wrong window size.