Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InputText with popup #6915

Closed
pavledev opened this issue Oct 11, 2023 · 1 comment
Closed

InputText with popup #6915

pavledev opened this issue Oct 11, 2023 · 1 comment
Labels

Comments

@pavledev
Copy link

pavledev commented Oct 11, 2023

Version/Branch of Dear ImGui:

Version: 1.90 WIP
Branch: docking

Back-end/Renderer/Compiler/OS

Back-ends: imgui_impl_win32.cpp + imgui_impl_dx11.cpp
Compiler: VS2022
Operating System: Windows 10

My Issue/Question:

Code for rendering InputText with popup from here #718 (comment) causes IM_ASSERT(window == window->RootWindow); assert to fail https://github.com/ocornut/imgui/blob/docking/imgui.cpp#L7693 after popup and window are closed

@ocornut ocornut added the popups label Oct 12, 2023
ocornut added a commit that referenced this issue Oct 12, 2023
@ocornut
Copy link
Owner

ocornut commented Oct 12, 2023

I think the assert (added in 936f532) was incorrect here, pushed fix 0860671.
I will work on a regression test as this is rather subtle / fringe case to combine the Popup and Child flags and not tested enough.
Thank you!

@ocornut ocornut closed this as completed Oct 12, 2023
ocornut added a commit to ocornut/imgui_test_engine that referenced this issue Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants