-
-
Notifications
You must be signed in to change notification settings - Fork 10.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#3998 breaks GL_CLIP_ORIGIN on OpenGL contexts < 4.5 #4170
Comments
Hello, |
Could you run code of that sort: |
Yes, I checked, and I have the |
Pushed a fix for it. |
Thanks, it looks like it's working with both cards I can test with. |
I just updated to ImGui 1.83 from 1.79, and my gui is upside down again :(
Since #3998
GL_CLIP_ORIGIN
is only checked for opengl contexts >= 4.5, but my application actually request 3.3 context and uses theGL_ARB_clip_control
extension, which defines the same function and enum values as OpenGL 4.5. (And for example, the nvidia driver gives me a 3.3 core context, where the gui is now upside down and buggy, but the intel driver gives me a 4.5 core context, and everything is fine...)Unfortunately the opengl backend doesn't parse the list of extensions, so it'd either have to do that, or use the info from the loader (most loaders expose this info, but in a different way). I'm not sure how widespread this functionality in the wild, but seeing how much trouble it causes, I would be even okay with a solution where the backend doesn't try to figure this out on its own, and instead
ImGui_ImplOpenGL3_RenderDrawData
receives an extra bool parameter (basically the currentcurrent_clip_origin
variable, default to true so normal GL apps continue to work). Not sure what is the best solution.Version/Branch of Dear ImGui:
Version: 1.83
Branch: master
Back-end/Renderer/Compiler/OS
Back-ends: imgui_impl_opengl3.cpp + imgui_impl_glfw.cpp
Operating System: Linux
The text was updated successfully, but these errors were encountered: