BACKOFFICE FE/UI/Labeling Tool: Update UI/UX handle qc_status #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
choipd
suggested changes
Sep 5, 2022
There was a problem hiding this comment.
[major]
- There are many files changed. This makes code review hard. Please separate PR by intention.
- Please describe the detail what you trying to change in PR description
- Please try not to change the previous code format. This makes many changes which are not related this PR.
choipd
reviewed
Sep 5, 2022
choipd
reviewed
Sep 5, 2022
choipd
reviewed
Sep 5, 2022
choipd
reviewed
Sep 5, 2022
cuongho2
commented
Sep 5, 2022
cuongho2
changed the title
@choipd, I will remember and description indent task detail more than, thank for you advise. |
|
@choipd , can you approve my new change code. |
choipd
reviewed
Sep 6, 2022
| import {CSSHelper} from '../../../logic/helpers/CSSHelper'; | ||
| import {APIService} from '../../../services/API'; | ||
| import {PopupWindowType} from '../../../data/enums/PopupWindowType'; | ||
| import { Input } from '@material-ui/core'; |
There was a problem hiding this comment.
[Minor]
Please keep the previous code format. It would be nice to focus on which part of the codes changed.
There was a problem hiding this comment.
@choipd, I was change code to previous in this view.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-flight checklist