Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: json output for plugins list #609

Merged
merged 5 commits into from
May 24, 2023
Merged

Conversation

mshanemc
Copy link
Member

@mshanemc mshanemc commented May 23, 2023

add --json for x plugins command.

side effect

  • significantly extends UT timeout limit for windows (this should unblock some of the dependabot PRs)

forcedotcom/cli#267
@W-13472231@

QA: you can plugins:link this, but sometimes you'll end up in a broken state when uninstalling it and will need to re-install the CLI?

@WillieRuemmele
Copy link

QA Notes


✅ : now has a --json flag to print results as json

➜  plugin-plugins git:(sm/plugins-list-with-json) 
 ➜  sfdx plugins --json
 ›   Error: Nonexistent flag: --json
 ›   See more help with --help
➜  plugin-plugins git:(sm/plugins-list-with-json) 
 ➜  spl .
@salesforce/cli: linking plugin @oclif/plugin-plugins... ⣯ [3/5] Fetching packages...
warning "oclif > [email protected]" has unmet peer dependency "mem-fs@^1.2.0 || ^2.0.0".
warning "oclif > [email protected]" has unmet peer dependency "mem-fs-editor@^8.1.2 || ^9.0.0".
@salesforce/cli: linking plugin @oclif/plugin-plugins... done
➜  plugin-plugins git:(sm/plugins-list-with-json) 
 ➜  sfdx plugins --json
[
  {
    "name": "@salesforce/plugin-dev",
    "tag": "0.7.6",
    "type": "user"
  },
  {
    "name": "@salesforce/plugin-signups",
    "tag": "1.4.18",
    "type": "user"
  },
  {
    "name": "@salesforce/plugin-packaging",
    "tag": "1.17.0",
    "type": "user"
  },
  {
    "type": "link",
    "name": "@oclif/plugin-update",
    "root": "/Users/william.ruemmele/projects/oclif/plugin-update"
  },
  {
    "type": "link",
    "name": "@salesforce/plugin-deploy-retrieve",
    "root": "/Users/william.ruemmele/projects/oss/plugin-deploy-retrieve"
  },
  {
    "type": "link",
    "name": "@oclif/plugin-plugins",
    "root": "/Users/william.ruemmele/projects/oclif/plugin-plugins"
  }
]

✅ : no plugins - couldn't run it from sfdx because it's linked to get the --json flag 🤪

 ➜  ./bin/dev plugins --json
[]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants