Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: identify when the command is meant to be 'help' #409

Merged
merged 5 commits into from
Jul 11, 2023

Conversation

WillieRuemmele
Copy link
Contributor

@W-13649156@
forcedotcom/cli#2240

this could potentially be wholly fixed in the tax-free code in oclif/core

 ➜  sf package help
 ›   Warning: package help is not a sf command.
Did you mean help package? [y/n]: y
Create a package.

USAGE
  $ sf package COMMAND
 ➜  sf package help list                         
 ›   Warning: package help list is not a sf command.
Did you mean help package list? [y/n]: y
List all packages in the Dev Hub org.

USAGE
  $ sf package list -v <value> [--json] [--api-version <value>] [--verbose]

@mshanemc
Copy link
Member

mshanemc commented Jul 11, 2023

QA:

base condition:
✅ works great. Gets me to help faster.

❌ with a flag (✅ fixed by commit below)

 ›   Warning: org list help is not a sf command.
Did you mean help org list? [y/n]: y
 ›   Error: Nonexistent flag: --clean
 ›   See more help with --help

if we're in the help path maybe we should build the command name from its ID rather than retaining the args/flags?

@mshanemc mshanemc merged commit 946a8cd into main Jul 11, 2023
@mshanemc mshanemc deleted the wr/didYouMeanHelp branch July 11, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants