feat!: use oclif/core v4 #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: remove table-related flags and standardize return value
iowillhoit
reviewed
May 31, 2024
src/commands/commands.ts
Outdated
| // @ts-expect-error because object-treeify does not have types: https://github.com/blackflux/object-treeify/issues/1077 | ||
| import treeify from 'object-treeify' | ||
| import TtyTable from 'tty-table' | ||
| // import {EOL} from 'node:os' |
iowillhoit
reviewed
May 31, 2024
src/commands/commands.ts
Outdated
|
|
||
| import createCommandTree from '../utils/tree.js' | ||
| // import createCommandTree from '../utils/tree.js' |
There was a problem hiding this comment.
fixed - sorry for being sloppy!
|
By default, the command name should not be truncated. Also, ideally the full command name (currently seeing with Truncated: Wrapping command names: Before this PR: |
|
Much better! Looks good |
iowillhoit
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: remove table-related flags and standardize return value
--csv--filter--no-header--output@W-15845231@