fix: falsy arg default (#40)

Fixes #39
oclif · Oct 17, 2018 · 2e73b4b · 2e73b4b
1 parent af00006
commit 2e73b4b
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/src/parse.ts b/src/parse.ts
@@ -217,7 +217,7 @@ export class Parser<T extends ParserInput, TFlags extends OutputFlags<T['flags']
           args[i] = token.input
         }
       } else {
-        if (arg.default) {
+        if ('default' in arg) {
           if (typeof arg.default === 'function') {
             args[i] = arg.default()
           } else {

diff --git a/test/parse.test.ts b/test/parse.test.ts
@@ -324,6 +324,13 @@ See more help with --help`)
       expect(out.flags).to.deep.include({foo: 'bar'})
     })
 
+    it('accepts falsy', () => {
+      const out = parse([], {
+        args: [{name: 'baz', default: false}],
+      })
+      expect(out.args).to.deep.include({baz: false})
+    })
+
     it('default as function', () => {
       const out = parse([], {
         args: [{name: 'baz', default: () => 'BAZ'}],