fix: provide region to S3Client

oclif · Jan 9, 2024 · de0d28f · de0d28f
1 parent 4d20e8a
commit de0d28f
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 6 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -33,7 +33,6 @@ jobs:
         env:
           AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
           AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
-          AWS_REGION: us-east-1
           PRESERVE_ARTIFACTS: ${{ vars.PRESERVE_ARTIFACTS }}
 
   integration:
@@ -80,7 +79,6 @@ jobs:
         env:
           AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
           AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
-          AWS_REGION: us-east-1
           PRESERVE_ARTIFACTS: ${{ vars.PRESERVE_ARTIFACTS }}
 
   mac-build:
@@ -102,7 +100,6 @@ jobs:
         env:
           AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
           AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
-          AWS_REGION: us-east-1
           PRESERVE_ARTIFACTS: ${{ vars.PRESERVE_ARTIFACTS }}
 
   deb-build:
@@ -128,6 +125,5 @@ jobs:
         env:
           AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
           AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
-          AWS_REGION: us-east-1
           OCLIF_DEB_KEY: ${{ secrets.OCLIF_DEB_KEY }}
           PRESERVE_ARTIFACTS: ${{ vars.PRESERVE_ARTIFACTS }}
diff --git a/bin/dev.js b/bin/dev.js
@@ -1,6 +1,6 @@
 #!/usr/bin/env ts-node
 // eslint-disable-next-line node/shebang, unicorn/prefer-top-level-await
-(async () => {
+;(async () => {
   const oclif = await import('@oclif/core')
   await oclif.execute({development: true, dir: __dirname})
 })()
diff --git a/bin/run.js b/bin/run.js
@@ -1,7 +1,7 @@
 #!/usr/bin/env node
 
 // eslint-disable-next-line unicorn/prefer-top-level-await
-(async () => {
+;(async () => {
   const oclif = await import('@oclif/core')
   await oclif.execute({dir: __dirname})
 })()
diff --git a/src/aws.ts b/src/aws.ts
@@ -57,6 +57,7 @@ const aws = {
           credentials: this.creds,
           endpoint: process.env.AWS_S3_ENDPOINT,
           forcePathStyle: Boolean(process.env.AWS_S3_FORCE_PATH_STYLE),
+          region: process.env.AWS_REGION ?? 'us-east-1',
         })
       return cache.s3
     } catch (error: unknown) {