Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add commandGlobPatterns option #943

Closed
wants to merge 1 commit into from

Conversation

mdonnalley
Copy link
Contributor

@mdonnalley mdonnalley commented Feb 8, 2024

Make the glob pattern for finding command files inside configured commands directory configurable.

{
  "oclif": {
     "commands": "./dist/commands",
     "commandGlobPatterns": [
       "**/*.command.*",
       "!**/*.+(d.*|test.*|spec.*|helpers.*)?(x)"
     ], 
  }
}

Fixes oclif/oclif#1053
@W-15000333@

@coltenkrauter
Copy link

Looking forward to this getting merged. #1053

@kamal94
Copy link

kamal94 commented Feb 9, 2024

This is awesome. Thanks @mdonnalley!

Copy link
Member

@mshanemc mshanemc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 windows nuts are failing

@mdonnalley mdonnalley closed this Feb 13, 2024
@mdonnalley mdonnalley deleted the mdonnalley/configure-globs branch February 13, 2024 15:13
@mdonnalley
Copy link
Contributor Author

Going with #945 instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Structuring with folders within command leads to errors
4 participants