fix: change useable ids to set to improve search perf #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdonnalley
requested changes
Feb 27, 2023
src/help/util.ts
Outdated
| @@ -41,10 +41,10 @@ function collateSpacedCmdIDFromArgs(argv: string[], config: IConfig): string[] { | |||
| if (argv.length === 1) return argv | |||
|
|
|||
| const findId = (argv: string[]): string | undefined => { | |||
| const ids = collectUsableIds(config.commandIDs) | |||
| const ids = new Set(collectUsableIds(config.commandIDs)) | |||
There was a problem hiding this comment.
@peternhale would it be better to have collectUsableIds return a Set? That way other consumers of it get the performance benefits?
There was a problem hiding this comment.
I'll take a look, but yes. would also save the sort op in collectUsableIds
mdonnalley
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple change to improve command lookup perf