fix: handling quoted strings and options validation for comma-delimited multiple-flag #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdonnalley
previously approved these changes
Feb 7, 2023
test/parser/parse.test.ts
Outdated
| it('allowed options on multiple', async () => { | ||
| const out = await parse(['--foo', 'a', '--foo=b'], { | ||
| flags: { | ||
| foo: Flags.custom({multiple: true, parse: async i => i, options: ['a', 'b']})(), |
There was a problem hiding this comment.
Any particular reason for using Flag.custom and defining a parse? It's not an issue, it just would be more concise to do this:
Flags.string({multiple: true, options: ['a', 'b']})
peternhale
reviewed
Feb 7, 2023
src/parser/parse.ts
Outdated
| const values = await Promise.all( | ||
| input.split(flag.delimiter).map(async v => this._parseFlag(v.trim(), flag, token)), | ||
| input.split(flag.delimiter).map(async v => this._parseFlag(v.trim().replace(/^"(.*)"$/, '$1'), flag, token)), |
There was a problem hiding this comment.
@mshanemc should this also consider signle quotes, 'a b' 'c d'?
There was a problem hiding this comment.
yeah, I think so. posix-shells could
mdonnalley
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
side note about error messages assertion changes:
test cases would run find from
yarn testbut fail when running the individual test becuase of ASCII color codes in the results. They've been modified to "include" the expected strings to make them color-blindfixes forcedotcom/cli#1936