Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update isProd utility #368

Merged
merged 1 commit into from
Feb 9, 2022
+1 −1
Merged

fix: update isProd utility #368

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/util.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,5 +37,5 @@ export function castArray<T>(input?: T | T[]): T[] {
}

export function isProd() {
return process.env.NODE_ENV !== 'development'
return !['development', 'test'].includes(process.env.NODE_ENV ?? '')
Copy link
Contributor

@RodEsp RodEsp Feb 9, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please try to err on the side of more readable code?

I would much rather see something like return process.env.NODE_ENV !== 'development' && process.env.NODE_ENV !== 'test'. It's so much easier to parse what exactly that code does and intends to do than something like this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdonnalley, @peternhale fyi ^

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about?
return !['development', 'test'].some(mode => mode === (process.env.NODE_ENV ?? '')

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can go even simpler. How about?
return !['development', 'test'].reduce((prev, curr) => curr === (process.env.NODE_ENV ?? '') || prev, false)

}