ux.Table: Incorrect parsing of double quotes when exporting to CSV

[julesbonnard]

Describe the bug
The CSV output of ux.Table only escapes the first double quote of a string value, resulting in a bad CSV format when exporting string values with multiple double quotes followed by a comma.

To Reproduce
Try exporting with --csv flag a table containing the following string: "That film", a great movie.
You get this wrong result: """That film", a great movie"

Expected behavior
According to CSV spec If double-quotes are used to enclose fields, then a double-quote appearing inside a field must be escaped by preceding it with another double quote., the correct export should be """That film"", a great movie"

Additional context
Problem seems to come from this line :

core/src/cli-ux/styled/table.ts

Line 153 in 6b9af08

return values.map((e) => (lineToBeEscaped ? `"${e.replace('"', '""')}"` : e))

, where replaceAll should be used instead of replace.

Also, it would be great to only escape values containing characters like double quotes, commas and line breaks, and not the entire line

Thanks for your help

[mdonnalley]

@julesbonnard Sounds like you've around got your head wrapped around a solution - any chance you'd be willing to submit a PR?

[julesbonnard]

Sure, I'm not used to but I'll try. Le jeu. 22 févr. 2024, 22:41, Mike Donnalley ***@***.***> a écrit :

…

@julesbonnard <https://github.com/julesbonnard> Sounds like you've around got your head wrapped around a solution - any chance you'd be willing to submit a PR? — Reply to this email directly, view it on GitHub <#944 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABD4XFQYWSJL6KLAWYVT5UDYU63PHAVCNFSM6AAAAABDARO3GOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRQGM3DINBUGE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[mdonnalley]

Closed by #980