Skip to content
This repository has been archived by the owner on Feb 1, 2022. It is now read-only.

feat: add tree #57

Merged
merged 4 commits into from
Oct 10, 2018
Merged

feat: add tree #57

merged 4 commits into from
Oct 10, 2018

Conversation

RasPhilCo
Copy link
Contributor

No description provided.

@RasPhilCo RasPhilCo requested a review from jdx October 4, 2018 21:41
@codecov
Copy link

codecov bot commented Oct 4, 2018 •
edited
Loading

Codecov Report

Merging #57 into master will increase coverage by 4.28%.
The diff coverage is 78.26%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #57      +/-   ##
==========================================
+ Coverage   46.64%   50.92%   +4.28%     
==========================================
  Files          13       14       +1     
  Lines         298      377      +79     
  Branches       67       80      +13     
==========================================
+ Hits          139      192      +53     
- Misses        129      151      +22     
- Partials       30       34       +4
Impacted Files Coverage Δ
src/deps.ts 57.89% <100%> (+2.33%) ⬆️
src/index.ts 62.31% <100%> (+3.05%) ⬆️
src/styled/tree.ts 76.19% <76.19%> (ø)
src/styled/object.ts 66.66% <0%> (-11.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 251fd17...62a19e4. Read the comment docs.

@RasPhilCo RasPhilCo mentioned this pull request Oct 5, 2018
Merged
2 tasks
jdx
jdx reviewed Oct 5, 2018
View reviewed changes
src/styled/tree.ts
}

export default function tree() {
return new Tree()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may be wrong, but this looks like it makes a singleton tree. Can you use cli.tree() multiple times without it displaying the information from the previous tree?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, cli.tree() just instantiates a new Tree. Also, Tree is exported if folks want the ol'fashion'd way.

@RasPhilCo
Copy link
Contributor Author

@jdxcode ping

@RasPhilCo RasPhilCo merged commit 8d742a7 into master Oct 10, 2018
@RasPhilCo RasPhilCo deleted the supertree branch October 10, 2018 00:23
oclif-bot added a commit that referenced this pull request Oct 10, 2018
@oclif-bot
chore(release): 4.9.0 [skip ci]
336368a 
# [4.9.0](v4.8.2...v4.9.0) (2018-10-10)

### Features

* add tree ([#57](#57)) ([8d742a7](8d742a7))
@oclif-bot
Copy link
Contributor

🎉 This PR is included in version 4.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jdx jdx jdx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RasPhilCo @oclif-bot @jdx