Skip to content
This repository has been archived by the owner on Feb 1, 2022. It is now read-only.

Move @oclif/errors into dependencies #49

Merged
merged 1 commit into from
Aug 28, 2018
Merged

Move @oclif/errors into dependencies #49

merged 1 commit into from
Aug 28, 2018

Conversation

aulisius
Copy link
Contributor

Currently, @oclif/errors is in devDependencies, so when I npm install cli-ux, @oclif/errors is not available in node_modules which throws the following error:

Error: Cannot find module '@oclif/errors'

Doing a manual npm i @oclif/errors and then running the code is working.

This PR moves it to dependencies so that it'll be available in node_modules.

@codecov
Copy link

codecov bot commented Aug 28, 2018

Codecov Report

Merging #49 into master will decrease coverage by 2.5%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #49      +/-   ##
==========================================
- Coverage   49.15%   46.64%   -2.51%     
==========================================
  Files          13       13              
  Lines         354      298      -56     
  Branches       77       67      -10     
==========================================
- Hits          174      139      -35     
+ Misses        146      129      -17     
+ Partials       34       30       -4
Impacted Files Coverage Δ
src/index.ts 59.25% <0%> (-2.51%) ⬇️
src/styled/object.ts 77.77% <0%> (+11.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32a31d7...99b3da2. Read the comment docs.

@jdx jdx merged commit a9cf484 into oclif:master Aug 28, 2018
@oclif-bot
Copy link
Contributor

🎉 This PR is included in version 4.8.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

oclif-bot added a commit that referenced this pull request Aug 28, 2018
## [4.8.1](v4.8.0...v4.8.1) (2018-08-28)

### Bug Fixes

* Move `[@oclif](https://github.com/oclif)/errors` into `dependencies` ([#49](#49)) ([a9cf484](a9cf484))
@aulisius aulisius deleted the patch-1 branch August 28, 2018 18:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants