This repository has been archived by the owner on Feb 1, 2022. It is now read-only.
add wait #32
Merged
add wait #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #32 +/- ##
==========================================
- Coverage 46.17% 45.61% -0.56%
==========================================
Files 12 13 +1
Lines 327 331 +4
Branches 71 71
==========================================
Hits 151 151
- Misses 149 153 +4
Partials 27 27
Continue to review full report at Codecov.
|
jdx
reviewed
May 31, 2018
src/deps.ts
Outdated
| @@ -22,6 +22,7 @@ export const deps = { | |||
| get styledHeader(): typeof styledHeader.default { return fetch('./styled/header').default }, | |||
| get styledJSON(): typeof styledJSON.default { return fetch('./styled/json').default }, | |||
| get table(): typeof table.default { return fetch('./styled/table').default }, | |||
| get wait(): typeof table.default { return fetch('./wait').default }, | |||
There was a problem hiding this comment.
this type is wrong. I think you might be able to use the new import() syntax to make this better in typescript 2.9 too
jdx
suggested changes
May 31, 2018
jdx
approved these changes
May 31, 2018
oclif-bot
added a commit
that referenced
this pull request
May 31, 2018
<a name="4.5.0"></a> # [4.5.0](v4.4.1...v4.5.0) (2018-05-31) ### Features * add wait ([#32](#32)) ([5abcfa6](5abcfa6))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
type error microsoft/tslint-microsoft-contrib#355 (comment)