-
Notifications
You must be signed in to change notification settings - Fork 44
Allow multiple filter flags in Table #141
base: master
Are you sure you want to change the base?
Conversation
Thanks for the contribution! Unfortunately we can't verify the commit author(s): Arnulfo Solis <a***@A***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce.com Contributor License Agreement and this Pull Request will be revalidated. |
Thanks for the contribution! Before we can merge this, we need @arnulfojr to sign the Salesforce.com Contributor License Agreement. |
Codecov Report
@@ Coverage Diff @@
## master #141 +/- ##
==========================================
- Coverage 60.88% 0.00% -60.89%
==========================================
Files 15 9 -6
Lines 519 165 -354
Branches 110 37 -73
==========================================
- Hits 316 0 -316
+ Misses 180 165 -15
+ Partials 23 0 -23
Continue to review full report at Codecov.
|
@arnulfojr I don't get it. I can add multiple filters with version 5.4.5. Github says "This branch has no conflicts with the base branch", so I wonder, what did you exactly change? E.g. ./bin/run read -t payments --filter=charged=false --filter=firefundpercentage=100 -x rows where I pass the cli.table(dataList, convertToTableColumns(dataList), flags) |
You can pass that. But they are not processed. |
@MunifTanjim in my case they are processed and the table only renders the data that match my filters. If I get time I can create a reduced test case but I suspect that you have experienced an edge case, that I am not seeing. |
Data
|
Cool! Can you add a multiple filter test? If you'd rather pass to #156 that's fine too. |
Sorry for creating this PR out of the blue.
I wanted to be able to filter the table rows applying multiple filters.
Let's take this PR as a discussion starter:)