Change temporality for Counter and UpDownCounter to CUMULATIVE

Fixes open-telemetry#1383
ocelotl · Nov 16, 2020 · 4a6a1b5 · 4a6a1b5
1 parent f1db112
commit 4a6a1b5
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/.../opentelemetry-exporter-otlp/src/opentelemetry/exporter/otlp/metrics_exporter/__init__.py b/.../opentelemetry-exporter-otlp/src/opentelemetry/exporter/otlp/metrics_exporter/__init__.py
@@ -15,8 +15,7 @@
 """OTLP Metrics Exporter"""
 
 import logging
-import os
-from typing import List, Optional, Sequence, Type, TypeVar, Union
+from typing import List, Optional, Sequence, Type, TypeVar
 
 from grpc import ChannelCredentials
 
@@ -222,7 +221,8 @@ def _translate_data(
                         sdk_metric_record, data_point_class
                     ),
                     aggregation_temporality=(
-                        AggregationTemporality.AGGREGATION_TEMPORALITY_DELTA
+                        AggregationTemporality.
+                        AGGREGATION_TEMPORALITY_CUMULATIVE
                     ),
                     is_monotonic=True,
                 )
@@ -234,7 +234,8 @@ def _translate_data(
                         sdk_metric_record, data_point_class
                     ),
                     aggregation_temporality=(
-                        AggregationTemporality.AGGREGATION_TEMPORALITY_DELTA
+                        AggregationTemporality.
+                        AGGREGATION_TEMPORALITY_CUMULATIVE
                     ),
                     is_monotonic=False,
                 )

diff --git a/exporter/opentelemetry-exporter-otlp/tests/test_otlp_metric_exporter.py b/exporter/opentelemetry-exporter-otlp/tests/test_otlp_metric_exporter.py
@@ -133,7 +133,8 @@ def test_translate_metrics(self, mock_time_ns):
                                             )
                                         ],
                                         aggregation_temporality=(
-                                            AggregationTemporality.AGGREGATION_TEMPORALITY_DELTA
+                                            AggregationTemporality.
+                                            AGGREGATION_TEMPORALITY_CUMULATIVE
                                         ),
                                         is_monotonic=True,
                                     ),