Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBS - Setup of the project #5

Merged
merged 5 commits into from
Nov 22, 2022
Merged

DBS - Setup of the project #5

merged 5 commits into from
Nov 22, 2022

Conversation

balessan
Copy link
Collaborator

@balessan balessan commented Oct 29, 2022

Fixes #8

Changes proposed in this PR:

  • First implementation of the models needed to store every information in database
  • First endpoint implementation with the info, returning JSON formatted Data as follows:
[
  {
    "type": "filecoin",
    "description": "The file coin storage description.",
    "payment_methods": [
      {
        "chain_id": "1",
        "accepted_tokens": [
          {
            "OCEAN": "0xOCEAN_on_MAINNET"
          },
          {
            "DAI": "0xDAI_ON_MAINNET"
          }
        ]
      },
      {
        "chain_id": "polygon_chain_id",
        "accepted_tokens": [
          {
            "OCEAN": "0xOCEAN_on_POLYGON"
          },
          {
            "DAI": "0xDAI_ON_POLYGON"
          }
        ]
      }
    ]
  }
]

@happy-dev @alexcos20 : I am unsure about payment_methods. In the spec it is called payment but while processing it I was pretty sure it was actually the list of available payment methods for a given storage solution. Is that right ?

And about the list of accepted tokens, I do not really get why there is a multiplicity of accepted tokens by payment methods ?

So implementation of the first API public endpoint, but the easiest one. WIll now proceed with the POST on quotes and GET on quote.

Regards.

@alexcos20
Copy link
Member

please do not merge it, with failing tests ..

is this all so far ?

@balessan
Copy link
Collaborator Author

balessan commented Nov 9, 2022

@alexcos20 : Yes, that's just the setup step, I am working locally on the actual implementation, will push actual API endpoint by tomorrow night.

What's missing and what I would like to get information is target infrastructure for test deployment. Do you have any available target infrastructure ? Like heroku or something ?

@alexcos20
Copy link
Member

no, this will be backed as docker and we will run it in our infrastructure

@balessan
Copy link
Collaborator Author

balessan commented Nov 9, 2022

Ok, perfect, thanks for the answer.

@balessan balessan mentioned this pull request Nov 20, 2022
@balessan balessan merged commit cae2b9d into main Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storages list endpoint
2 participants