This repository has been archived by the owner on Aug 3, 2021. It is now read-only.
BestPrice updates #138
Merged
BestPrice updates #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kremalicious
force-pushed
the
feature/price-updates
branch
from
f0c7be4 to
efb4b12
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following oceanprotocol/ocean.js#340 & oceanprotocol/aquarius#286
pricereturned fromuseMetadatais now set first from the newddo.priceobject, and then fetches the price as before, and replaces the values. Also refactored to make sure there is no initializedoceanoraccountIdrequired to get that firstddo.price.And with that, this is finally possible, showing a price without any wallet: