Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added network name in logs. #669

Merged
merged 10 commits into from
Oct 26, 2023
Merged

Added network name in logs. #669

merged 10 commits into from
Oct 26, 2023

Conversation

mariacarmina
Copy link
Member

Fixes #644 .

Changes proposed in this PR:

  • add network name in logs

@mariacarmina mariacarmina self-assigned this Oct 9, 2023
@mariacarmina mariacarmina marked this pull request as draft October 9, 2023 13:24
@mariacarmina mariacarmina marked this pull request as ready for review October 9, 2023 13:30
ocean_provider/utils/basics.py Outdated Show resolved Hide resolved
Copy link
Member

@alexcos20 alexcos20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than that, lgtm , but I'm worried about tests

ocean_provider/utils/basics.py Show resolved Hide resolved
@mariacarmina mariacarmina merged commit 01144ec into main Oct 26, 2023
5 checks passed
@mariacarmina mariacarmina deleted the add-network-name-logs branch October 26, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add network-name in each of the provider logs
2 participants