Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce algo credentials check #667

Merged
merged 25 commits into from
Oct 6, 2023
Merged

Enforce algo credentials check #667

merged 25 commits into from
Oct 6, 2023

Conversation

mariacarmina
Copy link
Member

@mariacarmina mariacarmina commented Oct 3, 2023 •
edited
Loading

Fixes #657 .

Changes proposed in this PR:

  • enforce credentials check for algorithms
  • tests
  • delete unwanted images from the flow

@mariacarmina mariacarmina self-assigned this Oct 3, 2023
@mariacarmina
Copy link
Member Author

Connection refused error popped up again, needs investigation for the runner. Otherwise, the tests for algo credentials are passing previously in this commit

@mariacarmina mariacarmina marked this pull request as ready for review October 5, 2023 16:12
@mariacarmina
Copy link
Member Author

Fixed workflow

@mariacarmina mariacarmina requested a review from alexcos20 October 5, 2023 16:13
alexcos20
alexcos20 approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@alexcos20 alexcos20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mariacarmina mariacarmina merged commit a8c4db6 into main Oct 6, 2023
5 checks passed
@mariacarmina mariacarmina deleted the fix-algo-credentials branch October 6, 2023 12:31
@rogargon
Copy link

rogargon commented Oct 6, 2023

Great work @mariacarmina, thanks for fixing #657

@mariacarmina
Copy link
Member Author

Great work @mariacarmina, thanks for fixing #657

We'll release a new Provider soon as well with the latest modifications. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcos20 alexcos20 alexcos20 approved these changes

Assignees

@mariacarmina mariacarmina

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Credetials is not enforced, at least in the case of an algorithm
3 participants
@mariacarmina @rogargon @alexcos20