-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor user nonce logic. #649
Conversation
@mariacarmina i think there is a use case that is not well handled, if the address sent is a fresh one the provider returns a null response instead of creating a new entrance for the new address and return 0 maybe |
I suggest to create a new entry and return the new nonce value instead of 0 or null. |
yep agreed with the new nonce value, 0 was just a better alternative for null |
…for testing and nonce endpoint.
A fresh address will be stored as a new entry in a database with 1 as the nonce value. |
Tested on barge & mumbai a compute flow (end to end) and it worked as expected, without occurring |
@@ -46,7 +47,7 @@ def process_compute_request(data): | |||
|
|||
|
|||
def sign_for_compute(wallet, owner, job_id=None): | |||
nonce = datetime.now(timezone.utc).timestamp() | |||
nonce = datetime.now(timezone.utc).timestamp() * 1000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we handle this in a new issue, then lgtm
Fixes #648 .
Changes proposed in this PR: