Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document errors (follow-up) #625

Merged
merged 7 commits into from
Mar 28, 2023
Merged

Document errors (follow-up) #625

merged 7 commits into from
Mar 28, 2023

Conversation

calina-c
Copy link
Contributor

Closes #548.

@calina-c calina-c changed the title Document errors 2 Document errors (follow-up) Mar 27, 2023
@calina-c calina-c marked this pull request as ready for review March 27, 2023 10:43
@calina-c calina-c requested a review from mariacarmina March 27, 2023 10:43
mariacarmina
mariacarmina requested changes Mar 27, 2023
View reviewed changes
Copy link
Member

@mariacarmina mariacarmina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some tweaks

ocean_provider/routes/README.md Outdated Show resolved Hide resolved
ocean_provider/routes/README.md Outdated Show resolved Hide resolved
@calina-c calina-c force-pushed the document-errors-2 branch from fb628ef to ab30079 Compare March 28, 2023 09:51
@calina-c calina-c force-pushed the document-errors-2 branch from edb6d05 to 7cd9a19 Compare March 28, 2023 10:27
@calina-c calina-c force-pushed the document-errors-2 branch from 17a8776 to 9aae63a Compare March 28, 2023 11:05
mariacarmina
mariacarmina reviewed Mar 28, 2023
View reviewed changes
Copy link
Member

@mariacarmina mariacarmina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great! I have one more suggestion and that is to add a link where you say same as.... It's easier for users to redirect them exactly where you mention.

ocean_provider/routes/README.md Outdated Show resolved Hide resolved
@calina-c calina-c requested a review from mariacarmina March 28, 2023 12:25
@calina-c calina-c merged commit c8e50d9 into main Mar 28, 2023
@calina-c calina-c deleted the document-errors-2 branch March 28, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariacarmina mariacarmina mariacarmina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document provider errors
2 participants
@calina-c @mariacarmina