Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #633: Problem: cryptic Provider log messages #579

Merged
merged 8 commits into from
Apr 7, 2023

Conversation

alexcos20
Copy link
Member

@alexcos20 alexcos20 commented Dec 5, 2022

Fix #633

Problem: Provider has errors. When we go to debug, its logging is super cryptic which hurts ability to iterate.

Solution: add more debug code into Provider. So that when there is an issue, then it's way easier to debug.

Changes proposed in this PR:

  • adds more debug to logs

@alexcos20 alexcos20 self-assigned this Dec 5, 2022
@alexcos20 alexcos20 marked this pull request as ready for review January 3, 2023 10:38
@alexcos20 alexcos20 requested a review from calina-c January 3, 2023 10:38
@trentmc
Copy link
Member

trentmc commented Feb 28, 2023

Please link this to a github issue @alexcos20

And then let's see if we can get it over the line. Otherwise it will die on the vine

@trentmc
Copy link
Member

trentmc commented Mar 7, 2023

Status: Enzo had an issue. Alex needed to create a new image with more logging debug info.

@calina-c
Copy link
Contributor

Status right now: we have discussed this during the weekly calls repeatedly. We are waiting for Alex to come back from holiday to determine whether this stays or goes. In case it stays, we will create an issue and link it as needed.

@trentmc trentmc changed the title more debug Help debuggability, via more debug logs Apr 4, 2023
@trentmc trentmc changed the title Help debuggability, via more debug logs Fix #633: Problem: cryptic Provider log messages Apr 4, 2023
@calina-c calina-c self-requested a review April 7, 2023 06:30
@alexcos20 alexcos20 merged commit 8b6d4bb into main Apr 7, 2023
@alexcos20 alexcos20 deleted the feature/more_debug_on_files_validate branch April 7, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem: cryptic Provider log messages
3 participants