Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use validUntil in c2d payload #466

Merged
merged 23 commits into from
Jun 3, 2022
Merged

use validUntil in c2d payload #466

merged 23 commits into from
Jun 3, 2022

Conversation

alexcos20
Copy link
Member

@alexcos20 alexcos20 commented May 31, 2022 •
edited
Loading

Closes #465
Closes #471

@alexcos20 alexcos20 self-assigned this May 31, 2022
@alexcos20 alexcos20 requested a review from calina-c May 31, 2022 18:51
@alexcos20 alexcos20 marked this pull request as draft June 1, 2022 07:23
@alexcos20 alexcos20 marked this pull request as ready for review June 2, 2022 07:57
@calina-c calina-c force-pushed the bug/fix_c2d_providerFee_validUntil branch from d085f77 to e1fe259 Compare June 2, 2022 13:43
@calina-c calina-c force-pushed the bug/fix_c2d_providerFee_validUntil branch from 941c7e5 to a69e05d Compare June 2, 2022 13:52
calina-c
calina-c reviewed Jun 2, 2022
View reviewed changes
tests/test_compute.py Outdated Show resolved Hide resolved
calina-c
calina-c reviewed Jun 2, 2022
View reviewed changes
tests/test_helpers.py Outdated Show resolved Hide resolved
calina-c
calina-c suggested changes Jun 2, 2022
View reviewed changes
Copy link
Contributor

@calina-c calina-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though I previously approved this, it has evolved beyond its original scope, so I left a new code review.

@calina-c calina-c merged commit a7466a8 into v4main Jun 3, 2022
@calina-c calina-c deleted the bug/fix_c2d_providerFee_validUntil branch June 3, 2022 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calina-c calina-c calina-c approved these changes

Assignees

@alexcos20 alexcos20

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PROVIDER_FEE_TOKEN default - use Ocean Address C2d job cutoff
2 participants
@alexcos20 @calina-c