Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove matplotlib. #876

Merged
merged 3 commits into from
Apr 9, 2024
Merged

Remove matplotlib. #876

merged 3 commits into from
Apr 9, 2024

Conversation

calina-c
Copy link
Contributor

@calina-c calina-c commented Apr 9, 2024

Closes #869

@calina-c calina-c marked this pull request as ready for review April 9, 2024 12:33
@calina-c calina-c requested a review from trentmc April 9, 2024 12:33
@idiom-bytes
Copy link
Member

reviewed it as well, looks good

idiom-bytes
idiom-bytes approved these changes Apr 9, 2024
View reviewed changes
Copy link
Member

@idiom-bytes idiom-bytes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed it, thanks for removing hanging/final matplotlib hooks

@calina-c calina-c merged commit e6ef6db into main Apr 9, 2024
5 checks passed
@calina-c calina-c deleted the issue-869-remove-matplotlib branch April 9, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idiom-bytes idiom-bytes idiom-bytes approved these changes

@trentmc trentmc trentmc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Proposal] Remove matplotlib
3 participants
@calina-c @idiom-bytes @trentmc