Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #749 - Use streamlit to display graphs in sim plotter #793

Merged
merged 32 commits into from
Mar 28, 2024

Conversation

calina-c
Copy link
Contributor

Work on #749. Still using native matplotlib plots, but in a streamlit canvas.

@calina-c calina-c changed the title [WIP] Streamlit sim [WIP] Issue #749 - Use streamlit to display graphs in sim plotter Mar 14, 2024
@calina-c calina-c force-pushed the streamlit-sim branch 3 times, most recently from 64d8895 to 009d714 Compare March 27, 2024 11:48
@calina-c calina-c changed the title [WIP] Issue #749 - Use streamlit to display graphs in sim plotter Issue #749 - Use streamlit to display graphs in sim plotter Mar 27, 2024
@calina-c calina-c marked this pull request as ready for review March 27, 2024 13:40
@calina-c calina-c requested a review from idiom-bytes March 27, 2024 13:40
Copy link
Member

@idiom-bytes idiom-bytes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed every file, updates, and how the logic was restructured. Although there was a significant amount of cleanup, the core logic looks accurate.

Approving the PR.

@calina-c calina-c merged commit 29cf281 into main Mar 28, 2024
5 checks passed
@calina-c calina-c deleted the streamlit-sim branch March 28, 2024 08:00
@trentmc
Copy link
Member

trentmc commented Mar 28, 2024

It will be a common case to have an enormous number of variables. That's why it truncated in the original code.

@calina-c can you please create another github issue to handle this? Or do another bit for this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants