Fix #772 - TableRegistry Implementation #781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdetry
changed the title
idiom-bytes
reviewed
Mar 12, 2024
…g latest formatting
…formatting outputs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #772
Changes proposed in this PR:
TableRegistry Singleton: A new file
table_registry.pyhas been added. This file defines theTableRegistrysingleton, which manages access to the table objects.Refactor ETL Process: The
etl.pyfile has been modified to use theTableRegistrysingleton instead of directly accessingrecord_config[tables]. This centralizes the table management and makes the ETL process cleaner and more maintainable.Refactor GQLDataFactory: The
gql_data_factory.pyfile has been modified to work with the newTableRegistrysingleton.Refactor Bronze Table: The
table_bronze_pdr_predictions.pyfile has been modified to register itself with the TableRegistry singleton.Unit Tests: New unit tests have been added in test_table_registry.py to ensure the correct functionality of the
TableRegistrysingleton. Existing tests intest_gql_data_factory.pyhave been updated to work with the newTableRegistrysingleton.