Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dependencies/Pdr Dashboard ToDos] Upgrade dash[testing] #1647

Merged
merged 5 commits into from
Oct 3, 2024
Merged

[Dependencies/Pdr Dashboard ToDos] Upgrade dash[testing] #1647

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bd0fd5a
Upgrade dash testing and fix multi-ids for loading.
calina-c Oct 2, 2024
97c4e7d
Update dependencies.md
calina-c Oct 2, 2024
1c3a0a3
Merge branch 'main' into upgrade-dash-testing
calina-c Oct 2, 2024
43cb3ee
Revert a change to pytest ini settings.
calina-c Oct 2, 2024
29b7e50
Merge branch 'main' into upgrade-dash-testing
calina-c Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions READMEs/dependencies.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,6 @@ It also serves users who want to understand any issues and caveats in the instal
For more details, see the [the pytest-asyncio changelog](https://pytest-asyncio.readthedocs.io/en/latest/reference/changelog.html#id1), under Known Issues.
The library itself recommends using version 0.21 until the issue is resolved.

- `dash[testing]` is frozen at version 2.17.1. This is because we implemented some creative solutions to determine table header texts, which may break with newer versions.
Since the PDR Dashboard is still very actively developed, it is safer for us to freeze the version until we can update the codebase.

- `web3` is frozen at version 6.20.2. This is because of external dependencies with Barge and transactions. We are currently working on a solution to upgrade to the latest version.
More details can be found [here](https://github.com/oceanprotocol/pdr-backend/issues/1592) in the issue.

Expand Down
4 changes: 2 additions & 2 deletions pdr_backend/pdr_dashboard/assets/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ body {
text-align: center;
}

#loading {
.loading {
height: calc(100vh - 105px);
width: 100%;
}
Expand Down Expand Up @@ -357,7 +357,7 @@ button:hover{
.nav-link{
padding: 0 !important;
font-size: 28px;
font-weight: bold;
font-weight: bold;
margin-right: 20px;
}

Expand Down
2 changes: 1 addition & 1 deletion pdr_backend/pdr_dashboard/dash_components/view_elements.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ def get_metric(label, value, value_id):
},
),
dcc.Loading(
id="loading",
className="loading",
type="default",
children=html.Span(
format_value(value if value else 0, value_id),
Expand Down
2 changes: 1 addition & 1 deletion pdr_backend/pdr_dashboard/pages/home.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ def get_graphs_column(self):
[
self.get_graphs_column_metrics_row(),
dcc.Loading(
id="loading",
className="loading",
type="default",
children=self.get_graphs_column_plots_row(),
custom_spinner=html.H2(dbc.Spinner(), style={"height": "100%"}),
Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"bumpversion",
"ccxt==4.4.9",
"coverage",
"dash[testing]==2.17.1",
"dash[testing]==2.18.1",
"dash_bootstrap_components==1.6.0",
"dateparser==1.2.0",
"duckdb==1.1.1",
Expand Down
Loading