Feat #1202 - Fetch stake and accuracy per feed from live feeds #1295
Conversation
|
Good quick solution for calculating this 2 values, should offer much accurate environment for predictoor simulations. |
pdr_backend/sim/sim_engine.py
Outdated
| data = get_avg_stake_and_accuracy_for_feed(self.predict_feed) | ||
| if data: | ||
| self.others_accuracy, self.others_stake = data | ||
| self.others_stake = self.others_stake.amt_eth |
There was a problem hiding this comment.
I think the self.others_stake is referring to total stake for an epoch, but the stake amount from the api( self.others_stake ) is per day, so for an accurate stake you have to divide that by number of epochs
| tot_stake = others_stake + stake_amt | ||
| others_stake_correct = others_stake * pdr_ss.others_accuracy | ||
| tot_stake = self.others_stake + stake_amt | ||
| others_stake_correct = self.others_stake * self.others_accuracy |
There was a problem hiding this comment.
Just found another issue here, the self.others_accuracy value when accuracy endpoint data is used is in this format 52.3 which multiplied by total stake gives a higher value than the total stake.
I think what is expected is that the self.others_accuracy values is in this format 0.523, this was the others_stake_correct is a lower number than the self.others_stake
Possible fix is to divide the other_accuracy value by 100
|
Closing in lieu of #1257 |
#1298