Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use block timestamp instead of block number #12

Merged
merged 7 commits into from
Aug 3, 2023
Merged

Use block timestamp instead of block number #12

merged 7 commits into from
Aug 3, 2023

Conversation

trizin
Copy link
Contributor

@trizin trizin commented Aug 2, 2023 •
edited
Loading

Fixes #1

Changes proposed in this PR:

  • Use block timestamp instead of block number
  • Updated dfbuyer
  • Updated trueval
  • Updated predictoor
  • Updated trader

@trizin trizin linked an issue Aug 2, 2023 that may be closed by this pull request
Use block timestamp instead of block number #1
Closed
@trizin trizin marked this pull request as ready for review August 2, 2023 10:59
@trizin trizin requested review from alexcos20 and trentmc August 2, 2023 11:07
trentmc
trentmc requested changes Aug 2, 2023
View reviewed changes
Copy link
Member

@trentmc trentmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please write proper unit tests for each component, including testing for this.

(It will take some time but will greatly advance quality control.)

Once that's ready, lmk, I will re-review

@trizin
Copy link
Contributor Author

trizin commented Aug 3, 2023

Tests will be added in #13

@trizin trizin closed this Aug 3, 2023
@trizin trizin deleted the issue1-use-block-timestamp-instead-of-block-number branch August 3, 2023 08:11
@trizin trizin restored the issue1-use-block-timestamp-instead-of-block-number branch August 3, 2023 08:11
@trizin trizin reopened this Aug 3, 2023
@trizin trizin merged commit 18333df into main Aug 3, 2023
@trizin trizin deleted the issue1-use-block-timestamp-instead-of-block-number branch August 3, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trentmc trentmc trentmc requested changes

@alexcos20 alexcos20 Awaiting requested review from alexcos20

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use block timestamp instead of block number
2 participants
@trizin @trentmc