-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Issue1070 - Unix time natural_language: "now" and other commands are generating local time #1071
Fix Issue1070 - Unix time natural_language: "now" and other commands are generating local time #1071
Conversation
75c6c5e
to
5d3b4e8
Compare
I fixed the localisation, but I don't think the test is accurate to describe the problem. @KatunaNorbert is time.time() or time.gmtime() used in any relevant way for the ETL? If so, I think we need to reconsider those as well. |
Ref the failing CI tests, @idiom-bytes do you want to keep/adjust this test in particular, or will it suffice to add the timezone? I can (and probably will) add some tests using freezegun, which is much safer wrt. defining the time in tests (I think it already is a dependency) |
8f7fd34
to
35c0f0a
Compare
From what I see they are not used inside the ETL |
Tested it and the end date it's fixed now and it uses the local time to fetch from subgraph. |
As I understood it, my challenge, is that I didn't understand if "now" was to return local time or UTC time, and what the expectations from the lib was.... thank you for explaining @calina-c
|
…tural-language-now-wrong
35b3c94
into
issue685-duckdb-integration
Fixes #1070
We're running into issues where UnixTimeS and UnixTimeMs respond w/ timestamps that should be in UTC, but in reality are in local time. This is causing all sorts of issues in the data.
Changes proposed in this PR: