You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
trader_ss:
feed: binance BTC/USDT c 5msim_only:
buy_amt: 1000 USD # buy this amount in each epochfee_percent: 0.0# simulated % feeinit_holdings:
- 100000 USDT
- 2 BTCbot_only:
min_buffer: 30# in s. only trade if there's > this time leftmax_tries: 10# max no. attempts to process a feedposition_size: 3# buy/sell this amount in each epochexchange_only:
timeout: 30000options:
createMarketBuyOrderRequiresPrice": FalsedefaultType: spotsim_ss: # sim onlydo_plot: Truelog_dir: logsfinal_img_filebase: final_img # for name log_dir/{final_img_filebase}_{NR}.pngtest_n: 5000# number of epochs to simulatetradetype: histmock # histmock | livemock | liverealexchange_only:
timeout: 30000options:
createMarketBuyOrderRequiresPrice": FalsedefaultType: spot
The problem: exchange_only and its sub-values are in two places.
This gets reflected further downstream too.
This is a DRY violation. And, it's annoying from a UX perspective too: the user should really only have to change one place.
Candidate solutions
Create a new module ExchangeSS that has exchange_only and all the info below that. Then, both Trader and Simulator see this
Only have the info in TraderSS. Then, SimulatorSS also uses the info
TODO
Quick implementation experiment trying cand (1): will it be clean?
If yes to ^, build (1). Else build (2)
The text was updated successfully, but these errors were encountered:
trentmc
changed the title
[UX, Sim, Trader] DRY violation: PPSS specifies 'exchange_only' info in >1 place
[UX, Sim, Trader] DRY violation: 'exchange_only' given in >1 place
Mar 18, 2024
trentmc
changed the title
[UX, Sim, Trader] DRY violation: 'exchange_only' given in >1 place
[UX, Sim, Trader] DRY violations in specifying exchange
Mar 20, 2024
* Fix#806: DRY violations in exchange
* Fixed tests related to the removal of ccxt_exchange.
* Use binanceus in tests.
Co-authored-by: Calina Cenan <[email protected]>
The issue
Here's a snippet from ppss.yaml:
The problem:
exchange_only
and its sub-values are in two places.This gets reflected further downstream too.
This is a DRY violation. And, it's annoying from a UX perspective too: the user should really only have to change one place.
Candidate solutions
exchange_only
and all the info below that. Then, both Trader and Simulator see thisTODO
The text was updated successfully, but these errors were encountered: