Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sw eng] Add sim_ss_test_dict & lake_ss_test_dict to avoid DRY violations #791

Closed
trentmc opened this issue Mar 13, 2024 · 0 comments · Fixed by #792
Closed

[Sw eng] Add sim_ss_test_dict & lake_ss_test_dict to avoid DRY violations #791

trentmc opened this issue Mar 13, 2024 · 0 comments · Fixed by #792
Assignees
Labels
Type: Enhancement New feature or request

Comments

@trentmc
Copy link
Member

trentmc commented Mar 13, 2024

Background / motivation

predictoor_ss_test_dict() and similar have served me well, to avoid DRY violations.

For work in #779, I see that having sim_ss_test_dict & lake_ss_test_dict will avoid DRY violations there.

I am doing it as a separate PR, so that it's a simple well-contained refactoring.

TODOs / DoD

  • Add sim_ss_test_dict, update tests
  • Add lake_ss_test_dics, update tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant