Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Pdr bot] Check balances of both wallets before submitting prediction #702

Closed
trizin opened this issue Feb 29, 2024 · 0 comments · Fixed by #713
Closed

[Pdr bot] Check balances of both wallets before submitting prediction #702

trizin opened this issue Feb 29, 2024 · 0 comments · Fixed by #713
Labels
Type: Enhancement New feature or request

Comments

@trizin
Copy link
Contributor

trizin commented Feb 29, 2024

Check OCEAN and ROSEa balances of both wallets before submitting prediction. Do not submit if insufficient balance.
@trizin trizin added the Type: Enhancement New feature or request label Feb 29, 2024
@trentmc trentmc changed the title Check balances of both wallets before submitting prediction [Pdr bot] Check balances of both wallets before submitting prediction Mar 1, 2024
@trizin trizin linked a pull request Mar 1, 2024 that will close this issue
Fix #702: Check balances before submitting a prediction #713
Merged
@trentmc trentmc mentioned this issue Mar 3, 2024
Merged
trizin added a commit that referenced this issue Mar 18, 2024
@trizin
Fix #702: Check balances before submitting a prediction (#713)
14aaa88 
* Add and use check_balances function

* Correct vars

* Linter issues

* Formatting and fixes

* Add test_balance_check test

* Add token mock

* Add get_balance function mock

* make sure to use wei

* Linter fix

* Old school formatting

* Formatting

* Fix types

* Formatting

* Fix var names in test_balance_check

* Add properties up_addr and down_addr

* Better variable names and single line log

* native_token -> rose_token

* Add ROSE and OCEAN properties

* Fix attr

* Get tokens from web3 pp

* Formatting

* Add mock properties

* Fix typ

* Fix mocks

* Fix the mocks in test_balance_check test

* Remove unused funcs from mock

* Mock tokens in main pred test

* Fix mock

* Fix mock setup

* Fix mocks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #702: Check balances before submitting a prediction oceanprotocol/pdr-backend
1 participant
@trizin