Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor READMEs & add a README for trader #56

Closed
trizin opened this issue Aug 18, 2023 · 2 comments · Fixed by #59
Closed

Refactor READMEs & add a README for trader #56

trizin opened this issue Aug 18, 2023 · 2 comments · Fixed by #59
Assignees
Labels
Type: Enhancement New feature or request

Comments

@trizin
Copy link
Contributor

trizin commented Aug 18, 2023

.

@trizin trizin added the Type: Enhancement New feature or request label Aug 18, 2023
@trizin trizin self-assigned this Aug 18, 2023
@trentmc
Copy link
Member

trentmc commented Aug 19, 2023

This issue has issues:

  • "add a README for trader" is redundant with #51 "add a README for each agent"
  • "refactor READMEs" is ambiguously defined, and premature. #50 epic "MVP" includes README work, and is more precisely defined.

I see also that you have a branch issue56-refactor-readmes-add-a-readme-for-trader.

  • It adds a trader README.
  • It does't (yet) have refactoring

I recommend:

  • close this issue
  • don't do other refactoring in the branch
  • when the branch trader README is done, merge the branch as part of #51
  • then focus on the section in #51 called "Phase: Finalize system-level flows for local & remote-testnet", which includes better-defined README work

@trentmc trentmc changed the title Refactor readme's & add a readme for trader Refactor READMEs & add a README for trader Aug 19, 2023
@trentmc trentmc linked a pull request Aug 19, 2023 that will close this issue
@trentmc
Copy link
Member

trentmc commented Aug 19, 2023

I'm going forward with the recommendations of the previous comment.

close this issue

Doing it now

when the branch trader README is done, merge the branch as part of #51

I've created a PR, pointing to #51

then focus on the section in #51 called "Phase: Finalize system-level flows for local & remote-testnet", which includes better-defined README work

I'm gonna play with that a bit. @trizin you'll be able to see any of my progress in a branch. I update often:)

@trentmc trentmc closed this as completed Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants