Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lake] Integrate dydx into fetch_ohlcv.py & ohlcv_data_factory.py #493

Closed
10 tasks done
idiom-bytes opened this issue Jan 8, 2024 · 1 comment
Closed
10 tasks done
Assignees
Labels
Type: Enhancement New feature or request

Comments

@idiom-bytes
Copy link
Member

idiom-bytes commented Jan 8, 2024

Motivation

Parent epic: #492 "Explore DYDX towards making money: data_factory, trader, sim, and predictoor".

TODOs

  • [Step 1] Rename fetch_ohlcv.py::safe_fetch_ohlcv() -> safe_fetch_ohlcv_ccxt(). Ensure all tests pass. Merge PR into main. Update: done in commit 54b7038
  • [Step 2] In fetch_ohlcv.py, add a new method safe_fetch_ohlcv_dydx(). Add unit test(s) in test_fetch_ohlcv.py. Update: done in commit 188d022
    • Build functionality && Test: Happy path of fetching data without problems
    • Test: Gracefully handle nan values (vs floats). Update functionality as needed.
    • Test: Handle when coin or pair doesn't exist. ""
    • Test: Handle when bad start date or end date. ""
    • Test: Is there a limit on # points at once? (eg 1000). ""
    • Merge PR into main.
  • [Step 3] In fetch_ohlcv.py, add a new method safe_fetch_ohlcv() which takes in a specified exchange name, and passes through to either safe_fetch_ohlcv_ccxt() or safe_fetch_ohlcv_dydx(), depending on the exchange name. Add unit test(s). Merge PR into main.
  • [Step 4] Update ohclv_data_factory.py::OhlcvDataFactory._update_rawohlcv_files_at_feed() to use the (new) safe_fetch_ohlcv() interface, which means it will naturally support ccxt or dydx
@idiom-bytes idiom-bytes added the Type: Enhancement New feature or request label Jan 8, 2024
@trentmc trentmc changed the title Integrate dydx data into ohlcv_data_factory [YAML-CLI2, make $] Integrate dydx data into ohlcv_data_factory Jan 10, 2024
@trentmc trentmc changed the title [YAML-CLI2, make $] Integrate dydx data into ohlcv_data_factory [YAML, make $] Integrate dydx data into ohlcv_data_factory Jan 11, 2024
@trentmc trentmc changed the title [YAML, make $] Integrate dydx data into ohlcv_data_factory [Lake] Integrate dydx data into ohlcv_data_factory Jan 20, 2024
@trentmc trentmc changed the title [Lake] Integrate dydx data into ohlcv_data_factory [Lake] Integrate dydx into fetch_ohlcv.py & ohlcv_data_factory.py Feb 22, 2024
@graceful-coder
Copy link
Collaborator

Completed PR 1 of 4: #666

graceful-coder added a commit that referenced this issue Mar 8, 2024
* Added several unit tests for the new safe_fetch_ohlcv_dydx() function to make its testing comprehensive
* Fixed a bug in the safe_fetch_ohlcv_dydx() function that was returning an incorrect data structure
@trentmc trentmc assigned trentmc and unassigned graceful-coder Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants