Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 'No address associated with hostname' #97

Merged
merged 1 commit into from
Jan 9, 2021
Merged

Conversation

trentmc
Copy link
Member

@trentmc trentmc commented Jan 9, 2021

For #89, for the error reported in this comment: #89 (comment)

I was able to replicate it locally.

Notes:

  • originally the service had url aquarius.rinkeby.v3.dev-ocean.com (and similar for provider)
  • then we created the service aquarius.rinkeby.oceanprotocol.com, quite a while ago now. That's the ones we've been maintaining. The READMEs etc were not updated at the time. The old services at dev-ocean were / are still running.
  • ocean.py READMEs point to *.dev-ocean.com not *.oceanprotocol.com #93 was to update the READMEs etc. Done. Except the wrong new url was provided: it had the v3 in it, and it shouldn't have.
  • This PR fixes that problem.

@trentmc trentmc merged commit 36d67e7 into master Jan 9, 2021
@trentmc trentmc deleted the issue89 branch January 9, 2021 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant