fix ddo encrypt for browsers #822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdanfazakas
approved these changes
May 28, 2021
| @@ -146,12 +146,12 @@ export class MetadataCache { | |||
| * @return {Promise<String>} Hex encoded encrypted DDO. | |||
| */ | |||
| public async encryptDDO(ddo: any): Promise<any> { | |||
| const fullUrl = `${this.url}/api/v1/aquarius/assets/ddo/encrypt` | |||
| const fullUrl = `${this.url}/api/v1/aquarius/assets/ddo/encryptashex ` | |||
There was a problem hiding this comment.
Ideally we we stick to one form of encryption with one encrypt endpoint in Aquarius instead of adding multiple endpoints for one use case. If we want to support multiple types of encryptions then we should stick to REST principles and use the same endpoint, but with e.g. a body param
But I guess it's yet another hack for one use case. At least we should type what this methods returns which seems to be now Promise<string>.
And what's the implications for users who have used this encryptDDO method before, is this a breaking change for them?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning: Needs aquarius >=2.2.12