checkURL interface

.travis.yml

@@ -29,7 +29,6 @@ before_script:
   - export AQUARIUS_URI="http://172.15.0.5:5000"
   - export DEPLOY_CONTRACTS="true"
   - export CONTRACTS_VERSION=v0.5.7
-  - export PROVIDER_VERSION=latest
   - bash -x start_ocean.sh --no-dashboard 2>&1 > start_ocean.log &
   - cd ..
   - ./scripts/waitforcontracts.sh

src/provider/Provider.ts

@@ -11,6 +11,11 @@ import { DDO } from '../ddo/DDO'
 
 const apiPath = '/api/v1/services'
 
+export interface urlDetails {
+  valid: boolean
+  contentLength?: string
+  contentType?: string
+}
 /**
  * Provides an interface for provider service.
  * Provider service is the technical component executed
@@ -73,20 +78,23 @@ export class Provider extends Instantiable {
     }
   }
 
-  public async checkURL(url: string): Promise<Record<string, string>> {
+  /** Get URL details (if possible)
+   * @param {String} url
+   * @return {Promise<urlDetails>} urlDetails
+   */
+  public async checkURL(url: string): Promise<urlDetails> {
     const args = { url }
     try {
       const response = await this.ocean.utils.fetch.post(
         this.getCheckURLEndpoint(),
         decodeURI(JSON.stringify(args))
       )
 
-      const result = await response.json()
-
-      return result.result
+      const result: urlDetails = await response.json()
+      return result
     } catch (e) {
-      this.logger.error(e)
-      throw new Error('HTTP request failed')
+      const result: urlDetails = { valid: false }
+      return result
     }
   }
 

test/integration/Provider.test.ts

@@ -19,7 +19,13 @@ describe('Provider tests', () => {
   it('Check a valid URL', async () => {
     const url = 'https://s3.amazonaws.com/testfiles.oceanprotocol.com/info.0.json'
     const response = await ocean.provider.checkURL(url)
+    assert(response.valid === true)
     assert(response.contentLength === '1161')
     assert(response.contentType === 'application/json')
   })
+  it('Check a invalid URL', async () => {
+    const url = 'https://s3.amazonaws.com/testfiles.oceanprotocol.com/nosuchfile'
+    const response = await ocean.provider.checkURL(url)
+    assert(response.valid === false)
+  })
 })