Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Adds checkURL function to use provider endpoint. #540

Merged
merged 3 commits into from
Jan 13, 2021
Merged

Conversation

calina-c
Copy link
Contributor

@calina-c calina-c commented Jan 13, 2021

Supersedes #483. Closes #525.

@calina-c calina-c self-assigned this Jan 13, 2021
@codeclimate
Copy link

codeclimate bot commented Jan 13, 2021

Code Climate has analyzed commit 19b2e37 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 2

The test coverage on the diff in this pull request is 77.7% (50% is the threshold).

This pull request will bring the total coverage in the repository to 77.5% (0.0% change).

View more on Code Climate.

@calina-c calina-c requested a review from alexcos20 January 13, 2021 12:19
Copy link
Member

@alexcos20 alexcos20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alexcos20 alexcos20 merged commit 34f8b4a into main Jan 13, 2021
@alexcos20 alexcos20 deleted the checkurl branch January 13, 2021 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a function to check URL using the provider checkURL endpoint
2 participants