Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ropsten #492

Merged
merged 3 commits into from
Dec 10, 2020
Merged

add ropsten #492

merged 3 commits into from
Dec 10, 2020

Conversation

alexcos20
Copy link
Member

No description provided.

@alexcos20 alexcos20 self-assigned this Dec 9, 2020
Copy link
Contributor

@kremalicious kremalicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should just work™ over in market once we bump @oceanprotocol/contracts there too

@kremalicious
Copy link
Contributor

or not :-) oceanprotocol/market#294

And ocean.js loads the contracts so all good from that side.

@alexcos20
Copy link
Member Author

I'm going to merge it once we have aqua & provider deployed.

@codeclimate
Copy link

codeclimate bot commented Dec 9, 2020

Code Climate has analyzed commit b0068d2 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 77.5% (0.0% change).

View more on Code Climate.

@alexcos20 alexcos20 merged commit 70bab98 into main Dec 10, 2020
@alexcos20 alexcos20 deleted the feature/ropsten branch December 10, 2020 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants