Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle assets with low liquidity #468

Merged
merged 2 commits into from
Nov 24, 2020
Merged

Handle assets with low liquidity #468

merged 2 commits into from
Nov 24, 2020

Conversation

mihaisc
Copy link
Contributor

@mihaisc mihaisc commented Nov 23, 2020

isConsumable is :

  • 'true' when pool/exchange created and enough datatokens are available ( can we check for exchange?)
  • 'false' when pool/exchange created and not enough datatokens are avaialbe
  • '' when pool/exchange not created

`isConsumable` is : 
- 'true' when pool/exchange created and enough datatokens are available ( can we check for exchange?)
- 'false' when pool/exchange created and not enough datatokens are avaialbe
- '' when pool/exchange not created
Copy link
Member

@alexcos20 alexcos20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codeclimate
Copy link

codeclimate bot commented Nov 23, 2020

Code Climate has analyzed commit 48f2fd4 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 77.5% (0.0% change).

View more on Code Climate.

@trentmc trentmc added this to the V3.x milestone Nov 24, 2020
@kremalicious kremalicious removed this from the V3.x milestone Nov 24, 2020
@mihaisc mihaisc merged commit 181d260 into main Nov 24, 2020
@mihaisc mihaisc deleted the mihaisc-patch-1 branch November 24, 2020 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants