Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug when amountOut>=balanceOut #365

Merged
merged 2 commits into from
Oct 16, 2020
Merged

Conversation

alexcos20
Copy link
Member

No description provided.

@alexcos20 alexcos20 self-assigned this Oct 15, 2020
@alexcos20
Copy link
Member Author

I have moved the max add liquidity and max remove liquidity to 25% of the pool, in order to prevent sudden price movements.
(balancer hardcoded limits are 1/3 on adding and 1/2 on removing)

Copy link
Contributor

@0x3bfc 0x3bfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requires test ?

@alexcos20 alexcos20 requested a review from 0x3bfc October 16, 2020 06:05
@codeclimate
Copy link

codeclimate bot commented Oct 16, 2020

Code Climate has analyzed commit b341667 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 77.3% (0.0% change).

View more on Code Climate.

Copy link
Contributor

@0x3bfc 0x3bfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kremalicious kremalicious merged commit 09c83ee into main Oct 16, 2020
@kremalicious kremalicious deleted the bug/fix_price_calculation branch October 16, 2020 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants