Feature/custom provider #288
Conversation
src/ocean/Assets.ts
Outdated
| ): Promise<ServiceAccess> { | ||
| return { | ||
| type: 'access', | ||
| index: 2, | ||
| serviceEndpoint: this.ocean.provider.getConsumeEndpoint(), | ||
| serviceEndpoint: customProvider | ||
| ? customProvider + this.ocean.provider.getConsumeEndpointShort() |
There was a problem hiding this comment.
Isn't it better to let the customProvider have the complete endpoint instead of only the base url?
There was a problem hiding this comment.
from UX, it's difficult. what kind of services do the publisher wants in the ddo ? if he wants access & compute, then you need to input 2 URLs..
There was a problem hiding this comment.
I thought we decided we can't have both
|
What is being done to |
|
Code Climate has analyzed commit 2d989df and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 72.6% (50% is the threshold). This pull request will bring the total coverage in the repository to 75.2% (-0.2% change). View more on Code Climate. |
Co-authored-by: Matthias Kretschmann <[email protected]>
Co-authored-by: Matthias Kretschmann <[email protected]>
closes #278
closes #292