Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove checks from publishing. ADded chain ID check for ordering. #1875

Merged
merged 5 commits into from
Nov 20, 2024
Merged

Remove checks from publishing. ADded chain ID check for ordering. #1875

merged 5 commits into from
Nov 20, 2024

Conversation

mariacarmina
Copy link
Member

@mariacarmina mariacarmina commented Nov 18, 2024 •
edited
Loading

Fixes #1876 .

Changes proposed in this PR:

@mariacarmina mariacarmina self-assigned this Nov 18, 2024
@mariacarmina mariacarmina marked this pull request as ready for review November 18, 2024 13:40
@jamiehewitt15
Copy link
Member

What issue is this fixing?

@mariacarmina
Copy link
Member Author

What issue is this fixing?

It is not defined, I can create an issue for this PR, it was dicussed to add the chain ID checks for publishing and for ordering level.

paulo-ocean
paulo-ocean approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@paulo-ocean paulo-ocean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

jamiehewitt15
jamiehewitt15 approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@jamiehewitt15 jamiehewitt15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@mariacarmina mariacarmina merged commit 8687962 into main Nov 20, 2024
11 checks passed
@mariacarmina mariacarmina deleted the add-checks-for-orders-and-compute branch November 20, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulo-ocean paulo-ocean paulo-ocean approved these changes

@jamiehewitt15 jamiehewitt15 jamiehewitt15 approved these changes

@mihaisc mihaisc Awaiting requested review from mihaisc mihaisc is a code owner

@alexcos20 alexcos20 Awaiting requested review from alexcos20 alexcos20 is a code owner

@bogdanfazakas bogdanfazakas Awaiting requested review from bogdanfazakas bogdanfazakas is a code owner

Assignees

@mariacarmina mariacarmina

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add checks for chainID at ordering level
3 participants
@mariacarmina @jamiehewitt15 @paulo-ocean