Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating oasis exports #1860

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Updating oasis exports #1860

merged 1 commit into from
Oct 9, 2024

Conversation

jamiehewitt15
Copy link
Member

Fixes # .

Changes proposed in this PR:

  • Updating oasis exports

Copy link

codeclimate bot commented Oct 9, 2024

Code Climate has analyzed commit a29faee and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 71.5% (-3.0% change).

View more on Code Climate.

Copy link
Member

@mariacarmina mariacarmina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @jamiehewitt15. It was already on #1859. I can approve this as well.

@jamiehewitt15
Copy link
Member Author

Hello @jamiehewitt15. It was already on #1859. I can approve this as well.

Thanks, yeah I need these exported so I can use them in the cli. I'll create a new release

@jamiehewitt15 jamiehewitt15 merged commit 746d3eb into main Oct 9, 2024
11 checks passed
@jamiehewitt15 jamiehewitt15 deleted the updateExports branch October 9, 2024 08:28
@paulo-ocean
Copy link
Contributor

Hello @jamiehewitt15. It was already on #1859. I can approve this as well.

Thanks, yeah I need these exported so I can use them in the cli. I'll create a new release

you could also use the generic createAsset function, no need for the exports but anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants