Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

throw some error msgs if no tx #1857

Merged
merged 1 commit into from
Sep 25, 2024
Merged

throw some error msgs if no tx #1857

merged 1 commit into from
Sep 25, 2024

Conversation

paulo-ocean
Copy link
Contributor

Fixes #1856

Changes proposed in this PR:

  • just add some log errors when tx fails

Copy link

codeclimate bot commented Sep 25, 2024

Code Climate has analyzed commit c701652 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 0.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 75.5% (0.0% change).

View more on Code Climate.

Copy link
Member

@jamiehewitt15 jamiehewitt15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@paulo-ocean paulo-ocean merged commit 5136d10 into main Sep 25, 2024
11 checks passed
@paulo-ocean paulo-ocean deleted the issue-1856-improve-error branch September 25, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve some logging errors/messages when TX fails
2 participants